[not a bug] memberlist.php pagination and blank ?mode=

[ALEXIS]

http://www.phpbb.com/bugs/phpbb3/ticket ... t_id=27655

First I use fresh a phpBB 3.0.1. And I check "20 May 09.50 GMT+2" SVN branch.

Why memberlist pagination have a blank "?mode=" ?

* memberlist.php?mode=&start=1
* memberlist.php?mode=&first_char=d#memberlist


I open memberlist.php and analyse many lines:

First:

This is memberlist modes:

Kod: Tümünü seç

// Check our mode...
if (!in_array($mode, array('', 'group', 'viewprofile', 'email', 'contact', 'searchuser', 'leaders')))

Second:

line 1222 ( this is foreach for params, params list on line 1188 in "$check_params = array(" )

Kod: Tümünü seç

$params[] = $param;

line 1232 (why add mode in $params array and where use)

Kod: Tümünü seç

$params[] = "mode=$mode";

line 1234 (pagination variable and add params)

Kod: Tümünü seç

$pagination_url = append_sid("{$phpbb_root_path}memberlist.$phpEx", implode('&', $params));

Ok, my problem is line 1232, why add mode in $params array and where use this mode? I can't find any usable area ?

I comment and no more see blank "?mode=", and can't see only problem

Kod: Tümünü seç

//$params[] = "mode=$mode";

small problem is:

find:

Kod: Tümünü seç

<a href="{S_MODE_ACTION}&amp;first_char=a#memberlist">A</a>&nbsp;

replace:

Kod: Tümünü seç

<a href="{S_MODE_ACTION}?first_char=a#memberlist">A</a>&nbsp;

[ALEXIS]

I now find a useble mode, in search function

memberlist.php?sk=c&sd=a&username=*&mode=searchuser&start=1

My new changes is memberlist.php

Kod: Tümünü seç

      $params[] = "mode=$mode";

to

Kod: Tümünü seç

      if (!empty($mode))
      {
         $params[] = "mode=$mode";
      }